Added image tint color #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrcftci
reviewed
Jul 9, 2020
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
could you please use pdf instead of png slices? Then u'll be able to use one source for that
emrcftci
reviewed
Jul 9, 2020
| @@ -190,6 +213,7 @@ | |||
| </scenes> | |||
| <resources> | |||
| <image name="background" width="1280" height="1280"/> | |||
| <image name="glyphicons-basic-790-fish" width="32" height="32"/> | |||
There was a problem hiding this comment.
maybe u should change the name of the image. please set a name like the other ones.
emrcftci
reviewed
Jul 9, 2020
| @IBInspectable | ||
| var imageTintColor: UIColor { | ||
| get { | ||
| if let color = _imageTintColor { |
There was a problem hiding this comment.
guard let color = _imageTintColor else { return .white }
return color
emrcftci
reviewed
Jul 9, 2020
| @@ -15,7 +15,7 @@ | |||
| <key>CFBundlePackageType</key> | |||
| <string>FMWK</string> | |||
| <key>CFBundleShortVersionString</key> | |||
| <string>3.0.2</string> | |||
| <string>$(MARKETING_VERSION)</string> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use to have all my icons with one color (black in this case) and I change the color programmatically on iOs 13.
I have added a property to do that.