Repository navigation
[PPR-3116]: Add new events for promotions - #14
Merged
Merged
Conversation
Z7oussem
reviewed
Aug 26, 2025
Z7oussem
reviewed
Aug 26, 2025
| export type ClickEvents = "click.action" | "click.navigation" | "click.download" | "click.exit" | "self_promotion.click"; | ||
|
|
||
| export type PageEvents = "page.display" | "com.display"; | ||
| export type PageEvents = "page.display" | "com.display" | "self_promotion.impression"; |
There was a problem hiding this comment.
same for PageEvents type, making it more generic to void code change in the future
Z7oussem
reviewed
Aug 26, 2025
laurentdamien
force-pushed
the
PPR-3116_add-new-promo-events
branch
from
August 26, 2025 09:36
c5a5e98 to
284e713
Compare
Z7oussem
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.