fix(commoninjectionlib): unseting the groups_id fields when empty instead of setting it to 0#598
Open
TarekRemo wants to merge 2 commits intopluginsGLPI:mainfrom
Open
fix(commoninjectionlib): unseting the groups_id fields when empty instead of setting it to 0#598TarekRemo wants to merge 2 commits intopluginsGLPI:mainfrom
TarekRemo wants to merge 2 commits intopluginsGLPI:mainfrom
Conversation
Rom1-B
reviewed
Apr 1, 2026
stonebuzz
requested changes
Apr 2, 2026
stonebuzz
approved these changes
Apr 2, 2026
Rom1-B
approved these changes
Apr 2, 2026
Contributor
|
can you rebase |
…isting groups when the group column is empty in the import file
…setting the groups_id field
stonebuzz
reviewed
Apr 2, 2026
| // If the field is an id, we set it to 0 | ||
| $this->values[$itemtype][$field] = self::DROPDOWN_EMPTY_VALUE; | ||
| //If the field concernes groupds, unseting it instead of setting it to 0 in order to avoid associating the item to a non existing group (id 0) | ||
| $group_fields = ['groups_id_tech', 'groups_id', 'groups_id_normal']; |
Contributor
There was a problem hiding this comment.
Where come from this -> groups_id_normal
Contributor
Author
There was a problem hiding this comment.
Its one of the keys used by the plugin to map the import file column to a group field (see line 1700).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(commoninjectionlib): fix association of imported data with non-existing groups when the group column is empty in the import file
Checklist before requesting a review
Please delete options that are not relevant.
Description
ticket 43155 : fixes the association of imported data with non-existing groups when the group column is empty in the import file.