Skip to content

Fix 5186 type checking renegerate code #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2025
Merged

Fix 5186 type checking renegerate code #5199

merged 3 commits into from
May 27, 2025

Conversation

gvwilson
Copy link
Contributor

@gvwilson gvwilson requested a review from emilykl May 22, 2025 18:59
@gvwilson gvwilson self-assigned this May 22, 2025
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken regression this used to work labels May 22, 2025
@gvwilson gvwilson mentioned this pull request May 22, 2025
Closed
emilykl
emilykl approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Confirming that this seems to fix syntax highlighting in VSCode on my machine.

gvwilson added 2 commits May 25, 2025 08:43
@gvwilson
feat: restore type checking portion of code generation
86514e1 
-   Restore code removed in #4978.
-   (Partially) closes #5186.
-   Remove unneeded imports of `sys`.
@gvwilson
feat: restore type checking support in generated code
44907a3 
-   Restore code removed in #4978.
-   Add `test_path.png` to `.gitignore`.
-   Closes #5186.
@gvwilson gvwilson force-pushed the fix-5186-type-checking-renegerate-code branch from 848f68e to 44907a3 Compare May 25, 2025 12:48
@gvwilson
Copy link
Contributor Author

updated to remove sys imports and check again version 3.7

@kszlim
Copy link

kszlim commented May 27, 2025

I'm curious if there will be a (relatively quick) patch version released once this makes it in?

@gvwilson
Copy link
Contributor Author

@kszlim coming soon

@gvwilson gvwilson mentioned this pull request May 27, 2025
Open
@gvwilson gvwilson merged commit 7bc7ce5 into main May 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl emilykl approved these changes

Assignees

@gvwilson gvwilson

Labels
fix fixes something broken P1 needed for current cycle regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvwilson @kszlim @emilykl