Skip to content

fix: add narwhals to conda recipe #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2024
Merged

fix: add narwhals to conda recipe #4916

merged 3 commits into from
Dec 6, 2024

Conversation

LiamConnors
Copy link
Member

No description provided.

@gvwilson gvwilson requested a review from emilykl December 1, 2024 22:32
@gvwilson gvwilson added community community contribution fix fixes something broken infrastructure build process etc. labels Dec 1, 2024
@emilykl
Copy link
Contributor

emilykl commented Dec 2, 2024

@LiamConnors Under what circumstances is this meta.yaml file used? Is it just used by CI/development or by end users of Plotly.py?

@emilykl
Copy link
Contributor

emilykl commented Dec 5, 2024

@LiamConnors Under what circumstances is this meta.yaml file used? Is it just used by CI/development or by end users of Plotly.py?

Answered offline, the meta.yaml specifies dependencies to install when using conda install.

Ideally IMO we should have just a single source of truth for dependencies so we don't need to update them in two places but in the meantime yes let's add narwhals in here to fix the conda installs.

@emilykl
Copy link
Contributor

emilykl commented Dec 6, 2024

Note: build-doc step of the build CI is failing for a reason that seems unrelated to these changes — same failure is happening on master. @LiamConnors is investigating, but in the meantime I'm merging this branch anyway.

@emilykl emilykl merged commit 7252900 into master Dec 6, 2024
4 of 5 checks passed
@gvwilson gvwilson deleted the conda-update branch February 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken infrastructure build process etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants