Skip to content

fix: Omit ISO country codes list when copying topojson to dist folder #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Omit ISO country codes list when copying topojson to dist folder #7643

wants to merge 2 commits into from
+33 −27

Conversation

@camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Nov 17, 2025 •
edited
Loading

Description

Omit the ISO country codes list when copying the topojson during build preprocessing.

Closes #7636.

Changes

  • Linting/formatting
  • Update preprocess build step

Testing

  • Be on master
  • Run npm run preprocess
  • Note that the list has been copied into the dist folder
  • Discard changes
  • Switch to this branch
  • Run npm run preprocess
  • Note that the list has NOT been copied into the dist folder

emilykl
emilykl approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilykl emilykl emilykl approved these changes

@alexshoe alexshoe Awaiting requested review from alexshoe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: Preprocess build step copies ISO codes list to plotly.js dist/topojson folder

3 participants

@camdecoster @emilykl