Skip to content

fix: Update legend maxheight calculation logic #7483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: Update legend maxheight calculation logic #7483

wants to merge 12 commits into from

Conversation

camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Jul 21, 2025 •
edited
Loading

Description

Update the legend maxheight calculation logic to account for the legend being located above/below the plot. Closes #7473.

Changes

  • Updates the maxheight calculation logic
  • Moves the default calculation into the sizing method
  • Updates attribute description
  • Adds test mock for image comparison

Demo

Before After
image image

Testing instructions

  • Be on master
  • Create a mock using the config from this PR
  • Open the mock in Plotly DevTools
  • Note that the legend overlaps the plot
  • Switch to this branch
  • Open the mock in Plotly DevTools
  • Note that the mock shows up correctly

@camdecoster camdecoster marked this pull request as ready for review July 22, 2025 16:34
archmoj
archmoj reviewed Jul 24, 2025
View reviewed changes
@archmoj archmoj added bug something broken regression this used to work labels Jul 24, 2025
archmoj
archmoj reviewed Jul 24, 2025
View reviewed changes
@camdecoster camdecoster requested a review from emilykl July 30, 2025 20:10
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken and removed bug something broken labels Aug 5, 2025
emilykl
emilykl reviewed Aug 5, 2025
View reviewed changes
emilykl
emilykl reviewed Aug 5, 2025
View reviewed changes
emilykl
emilykl reviewed Aug 5, 2025
View reviewed changes
emilykl
emilykl requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments about the boolean logic and attribute description, otherwise looks good!

@camdecoster camdecoster requested a review from emilykl August 5, 2025 20:33
@emilykl
Copy link
Contributor

emilykl commented Aug 5, 2025

@camdecoster The new image test is failing, can you double check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj left review comments

@emilykl emilykl Awaiting requested review from emilykl

Requested changes must be addressed to merge this pull request.

Assignees

@camdecoster camdecoster

Labels
fix fixes something broken P1 needed for current cycle regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical legend sizing/positioning broken
4 participants
@camdecoster @emilykl @archmoj @gvwilson