Skip to content

horizontal legend width should be layout width #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p1-ra wants to merge 1 commit into
base: master
Choose a base branch
from
Open

horizontal legend width should be layout width #5108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/legend/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,9 @@ function computeLegendDimensions(gd, groups, traces, opts) {
opts._titleWidth + 2 * (bw + constants.titlePad)
)
);
if (!isVertical) {
Copy link
Contributor

@archmoj archmoj Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the syntax test,
no space required after if statement.

if(!isVertical) {

Also you could run syntax test locally using:

npm run test-syntax

opts._width = gs.w;
}

opts._height = Math.ceil(
Math.max(
Expand Down