Skip to content

Bugfix: Fix dcc.Markdown issues with <dccLink /> - #3960

Draft
KoolADE85 wants to merge 2 commits into
devfrom
bugfix/3951-markdown-rewrite
Draft

Bugfix: Fix dcc.Markdown issues with <dccLink />#3960
KoolADE85 wants to merge 2 commits into
devfrom
bugfix/3951-markdown-rewrite

Conversation

@KoolADE85

Copy link
Copy Markdown
Contributor

dcc.Markdown used dependencies that were fundamentally incompatible with our <dccLink /> implementation + React 19 deps.
This PR rewrites the Markdown component to use markdown internals that are compatible.
Along the way, it's converted to Typescript.

dcc.Link is also converted to Typescript (no functional change) so as not to introduce TS compile errors.

Testing notes:

  • while this is a rewrite, I intend for this to be included in a minor release: You can compare against the old Markdown.react.js implementation for parity
  • I added plenty of missing integration tests

Fixes #3951

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] dcc.Markdown with a <dccLink children="..." /> does not render children

1 participant