-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Canvas annotation app #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test use canvas util img for pyterract im…
Oss canvas layout
…nvas width, comment out IAM model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39 |
@sstripps1 you worked on this, right? Looks like. this got stuck in code review. |
@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date. |
okay, cool. Someone will have to run black on this and then we'll merge then. I suppose I could do that. unless... @AirballClaytonCalvin |
Happy to 'run black on this'. Although not 100% sure what that means. |
@AirballClaytonCalvin I can walk you thru it 💯 |
@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser. 'Callback error updating text-output.children' I am struggling to troubleshoot it right now. |
💃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 good to merge
Issue for app: #https://github.com/plotly/dash-customer-success/issues/255
App pull request
About
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
assets/
folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)]
lessen the volume of code that needs to be maintained.)