Skip to content

Conversation

gvwilson
Copy link
Collaborator

@gvwilson gvwilson commented May 13, 2025

  1. Minor typography fixes in CHANGELOG.md, CODE_OF_CONDUCT.md, and CONTRIBUTING.md.
  2. Switch from app.run_server to app.run in more_examples/*/*.py.
  3. Update use of Dash Mantine Compnents in more_examples/demo_stock_portfolio_dmc/app.py.

Note: filters do not appear to work correctly in more_examples/convert_units but that could be operator error - guidance would be appreciated.

Q: some of the examples in more_examples needed extra packages (listed below). Where should these be recorded?

  • dash-bootstrap-components
  • dash-iconify
  • dash-mantine-components
  • pandas
  • yfinance

@gvwilson gvwilson requested review from AnnMarieW and BSd3v May 13, 2025 13:44
@gvwilson gvwilson self-assigned this May 13, 2025
@gvwilson gvwilson added fix fixes something broken P1 needed for current cycle labels May 13, 2025
@BSd3v
Copy link
Collaborator

BSd3v commented May 13, 2025

I think as far as examples, what do you think about having them written above the code and commented out?

I'm not sure the examples are relevant with the docs though.

@AnnMarieW, what are your thoughts?

@AnnMarieW
Copy link
Collaborator

AnnMarieW commented May 13, 2025

Actually the docs and the more_examples folders were created before docs were available in the dash docs. All the relevant examples have been moved over there.

It might be better to delete all these files and examples as they are no longer maintained.

@gvwilson
Copy link
Collaborator Author

I am 100% in favor of deleting stuff - can you please confirm that I should close this PR and rm -rf the docs and more_examples directories? Anything else we can get rid of? In particular, are we maintaining/documenting DAG for languages other than Python?

@AnnMarieW
Copy link
Collaborator

There are a couple Medium articles that link to apps here. I think it would be good to keep those and add a requirements.txt and a README.md that links back to the article.

I can do that if you like.

@gvwilson
Copy link
Collaborator Author

Thanks @AnnMarieW - can you please send me the links to the Medium articles and I'll update this PR? I feel like I already ask enough other favors of you (and may need to ask more to get this stuff published).

@AnnMarieW
Copy link
Collaborator

Here’s the article with the link to an app here: https://medium.com/plotly/announcing-dash-ag-grid-fbb4a1c83e62

This one is linked to my dash-ag-grid-examples repo, so it’s not affected : https://medium.com/plotly/announcing-dash-ag-grid-fbb4a1c83e62

@gvwilson
Copy link
Collaborator Author

thanks everyone - I've updated the PR. Please let me know if it looks OK and I'll merge it, then get back to trying to figure out #355 and how to publish new versions of this package.

1. Minor typography fixes in `CHANGELOG.md`, `CODE_OF_CONDUCT.md`, and `CONTRIBUTING.md`.
1. Switch from `app.run_server` to `app.run` in `more_examples/*/*.py`.
1. Update use of Dash Mantine Compnents in `more_examples/demo_stock_portfolio_dmc/app.py`.
1. Add `README.md` in `docs` to explain that this copy of the docs is no longer maintained.
1. Add `README.md` in `more_examples` to explain how to set up and run the examples.
1. Rename custom tooltip example to `app.py` for consistency.
1. Explain where and how `AgGrid.py` is regenerated.
@BSd3v
Copy link
Collaborator

BSd3v commented May 14, 2025

@gvwilson, before you work with that PR, the issue for splitting and refactoring needs to be addressed.

Copy link
Collaborator

@BSd3v BSd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@gvwilson gvwilson merged commit d29e70f into main May 16, 2025
3 checks passed
@gvwilson gvwilson deleted the minor-fixes branch May 16, 2025 13:33
@AnnMarieW
Copy link
Collaborator

@gvwilson are you going to delete the more_examples folder and the unused apps in the docs folder in a separate PR?

@gvwilson
Copy link
Collaborator Author

I can do, but I don't want to break the link in your Medium post - if you're able to edit the latter, I can move the example somewhere else?

@AnnMarieW
Copy link
Collaborator

No problem - I'll do a new PR to remove the unnecessary files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixes something broken P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants