-
Notifications
You must be signed in to change notification settings - Fork 33
fix: bring more_examples
up to date and minor formatting fixes in docs
#377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think as far as examples, what do you think about having them written above the code and commented out? I'm not sure the examples are relevant with the docs though. @AnnMarieW, what are your thoughts? |
Actually the It might be better to delete all these files and examples as they are no longer maintained. |
I am 100% in favor of deleting stuff - can you please confirm that I should close this PR and |
There are a couple Medium articles that link to apps here. I think it would be good to keep those and add a requirements.txt and a README.md that links back to the article. I can do that if you like. |
Thanks @AnnMarieW - can you please send me the links to the Medium articles and I'll update this PR? I feel like I already ask enough other favors of you (and may need to ask more to get this stuff published). |
Here’s the article with the link to an app here: https://medium.com/plotly/announcing-dash-ag-grid-fbb4a1c83e62 This one is linked to my dash-ag-grid-examples repo, so it’s not affected : https://medium.com/plotly/announcing-dash-ag-grid-fbb4a1c83e62 |
thanks everyone - I've updated the PR. Please let me know if it looks OK and I'll merge it, then get back to trying to figure out #355 and how to publish new versions of this package. |
1. Minor typography fixes in `CHANGELOG.md`, `CODE_OF_CONDUCT.md`, and `CONTRIBUTING.md`. 1. Switch from `app.run_server` to `app.run` in `more_examples/*/*.py`. 1. Update use of Dash Mantine Compnents in `more_examples/demo_stock_portfolio_dmc/app.py`. 1. Add `README.md` in `docs` to explain that this copy of the docs is no longer maintained. 1. Add `README.md` in `more_examples` to explain how to set up and run the examples. 1. Rename custom tooltip example to `app.py` for consistency. 1. Explain where and how `AgGrid.py` is regenerated.
@gvwilson, before you work with that PR, the issue for splitting and refactoring needs to be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
@gvwilson are you going to delete the |
I can do, but I don't want to break the link in your Medium post - if you're able to edit the latter, I can move the example somewhere else? |
No problem - I'll do a new PR to remove the unnecessary files. |
CHANGELOG.md
,CODE_OF_CONDUCT.md
, andCONTRIBUTING.md
.app.run_server
toapp.run
inmore_examples/*/*.py
.more_examples/demo_stock_portfolio_dmc/app.py
.Note: filters do not appear to work correctly in
more_examples/convert_units
but that could be operator error - guidance would be appreciated.Q: some of the examples in
more_examples
needed extra packages (listed below). Where should these be recorded?dash-bootstrap-components
dash-iconify
dash-mantine-components
pandas
yfinance