[#1849] Exceptions from controllers are not detected in FunctionalTests#778
Closed
hsch wants to merge 5 commits intoplayframework:masterfrom
hsch:lighthouse-1849-patch
Closed
[#1849] Exceptions from controllers are not detected in FunctionalTests#778hsch wants to merge 5 commits intoplayframework:masterfrom hsch:lighthouse-1849-patch
hsch wants to merge 5 commits intoplayframework:masterfrom
hsch:lighthouse-1849-patch
Conversation
Contributor
hsch
commented
Jul 13, 2014
hsch
commented
- Fix for #1849
- Includes test cases that pass only with the fix, and fail without
- Made one test more robust with respect to timing
- Tests "continuations", "Promises", and "CRUD" are still unreliable, but hopefully not related to this change
|
play-1-3-x-pull-requests #235 SUCCESS |
|
play-1-3-x-pull-requests #236 SUCCESS |
Notalifeform
changed the title
Member
|
Rebase this PR in #937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.