Open
Conversation
Contributor
aleksandy
commented
Jan 21, 2026
- use toAray(IntFunction) instead of toArray(T[])
- optimize JavaExtensions#remove()
- simplify JavaExtensions#pad()
- simplify JavaExtensions#join()
- use primitives instead of wrappers
- use pattern matching instead of explicit cast
- use String.valueOf() and toString() for the objects stringification instead of concatenation with empty string
* simplify #pad() * simplify #join()
…nstead of concatenation with empty string
Contributor
Author
|
@xael-fry, @asolntsev, could you review my PR? |
aleksandy
commented
Jan 23, 2026
* optimize #bindParameters()
…es list in parameters
xael-fry
requested changes
Jan 31, 2026
Member
xael-fry
left a comment
There was a problem hiding this comment.
The MR is so called "cleanup" but it contains refactors,, fixes and all all parts off the code and not on a given part.
Please split your work in different MR, you can also use the conventional commit to have better description of the scope of the modification apply to.
Thanks
* use HexFormat instead of manual encoding to hex-string
Contributor
Author
|
I've updated the PR. Removed the replacement of Stack with Deque. The rest of the changes, in my opinion, are quite suitable for a cleanup. Old unused code was removed, some was rewritten using modern capabilities of the standard library and the language. |
Contributor
Author
|
@xael-fry, any news about PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.