-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update channels/source resolution #6422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aerosol
wants to merge
19
commits into
master
Choose a base branch
from
new-sources-channels-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
428b188
Simplify source resolution and normalize imported referrers
aerosol 229dcd6
Add Bluesky and Mastodon as Organic Social sources
aerosol 6e101f5
Add AI Assistants channel for AI tools
aerosol 277f8f7
Rename Twitter to X (Twitter)
aerosol dac25a9
Add favicon mappings for new sources and Linktree
aerosol 27a4558
Add referrer-source remap and acquisition_channel backfill migrations
aerosol 5fbde69
Add Kagi as Organic Search source
aerosol 1f2aff7
Rename Copilot to Microsoft Copilot and group copilot.com
aerosol 364111b
Group l.threads.com with Threads
aerosol a328b99
Group pplx.ai with Perplexity
aerosol 70d90d6
Extract helpers for acquisition tests
aerosol cb7b15d
Carry on refactoring tests, improve readibility
aerosol 27e0386
Remove dead channel entry
aerosol f574b9c
Add android-app://org.joinmastodon.android to custom sources
aerosol c158463
Add plain copilot entry to custom sources
aerosol afb66eb
Add missing remap
aerosol 1c62dbb
Remove dead custom sources
aerosol 96ef63f
Suffix WIP
aerosol ac77a89
Use single statement per table to remap sources
aerosol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly related to this PR but: To reduce a risk of a missed typo causing headaches, perhaps we could consider putting category string labels in module attributes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're used in sql eex 😅 - how would you make them available there for compile-time validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They could be put under module attribute as a map of
%{social: "SOURCE_CATEGORY_SOCIAL", ...}and then exposed via a function, which should be usable during compile time with no issues I think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, since this is currently mostly convenience, I'll follow-up in a separate change