Use assign instead of assign_async for pages breakdown query result
#5989
+59
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
remove-async-result-from-pages
branch
from
73b80bf to
07d5ecd
Compare
zoldar
force-pushed
the
remove-async-result-from-pages
branch
from
07d5ecd to
a8fd4fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change removes async assignment of query result in LV pages breakdown. As we rely on optimistic loading state, async assign is unnecessary and even counterproductive as it requires distinct handling of loading state (phx loading attribute is not set for the duration of loading it, it would have to be done with a hook).
Removal of async assign has uncovered a bug in navigation hook logic which led to intermittent double execution of "handle_params" event when navigating via LV clicks. This bug got addressed as well.
Tests