Goals with custom props (settings+filtering UI integration) #5977
Conversation
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
90d802d to
e861beb
Compare
|
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
0f70963 to
79098c7
Compare
sanne-san
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
3398dd5 to
0daac2f
Compare
aerosol
changed the title
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
c14f5a7 to
ded06ef
Compare
…pair - Add input and dropdown class attributes to combobox. - Adjust combobox dropdown within a property pair to overflow to max the width of the property pair container, with help of container-type:inline-size. - Ensure trash icon wrapper is hidden when icon is hidden. - Add title attribute to option when it is being truncated.
- Improve `Upgrade` CTA in list and turn it into a link - Improve `Upgrade` CTA tooltip copy to make it more clear what happens with locked goals on the dashboard - Add disabled (faded) styling to icon button and toggle switch - Move disabled styling to toggle only in goal form - Add `link_class` attribute to `upgrade_call_to_action` component in order to override link color when displayed inside tooltip - Add `Business` pill to goal form to make it more obvious that the feature is locked, and make it a link to the billing page - Improve prop styling inside tooltip in goal list to make it more readable and ensure truncation when prop is long
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
ded06ef to
4a39634
Compare
...e_web/controllers/api/external_stats_controller/query_goal_custom_props_equivalence_test.exs
Show resolved
Hide resolved
lib/plausible/stats/goals.ex
Outdated
| goals = | ||
| site | ||
| |> Plausible.Goals.for_site(include_goals_with_custom_props?: props_available?) |
There was a problem hiding this comment.
nitpick, non-blocking: I think the error emitted to Stats API users may be a bit misleading if we do it this way. It will say that the requested goal doesn't exist, even though it does, just is unavailable.
{
"error": "Invalid filters. The goal `...` is not configured for this site. Find out how to configure goals here: https://plausible.io/docs/stats-api#filtering-by-goals"
}
There was a problem hiding this comment.
We can update the documentation once this is live and state that goals with custom props might become unavailable in Stats API, if subscription does not cover props. Settings web UI will make that clear. cc @metmarkosaric
| <PlausibleWeb.Components.Billing.upgrade_call_to_action | ||
| current_user={@current_user} | ||
| current_team={@site_team} | ||
| link_class="!inline !text-indigo-400 hover:!text-indigo-300" |
There was a problem hiding this comment.
I was trying to see what these classes do but don't see a visible difference when I remove the line. Am I doing something wrong or are these not really doing anything? Here's what it looks to me with this line removed
There was a problem hiding this comment.
Yeah this is because the upgrade CTA appears inside a tooltip here. The tooltip is there for extra context if people try to click the toggle. This means that even in light mode, it appears on a dark background and becomes hard to read. These classes make sure it 1) reads as a single line and 2) it's more visible. With and without:
Changes
This PR implements full capability of managing goals with custom props via site settings + filtering the dashboard.
The PR builds upon #5978, #5944, #5946, #5952
Billing states, such as Props feature unavailable are handled with appropriate CTAs.
Preview env: https://pr-5977.review.plausible.io/
Documentation update + changelog entry pending.
Additionally, we'll prohibit editing existing revenue goals currency.
Sample screenshots:
record-2026-01-19-11-03-52-blob.ayes.cuba.mp4
record-2026-01-19-11-11-28-aunt.ribs.nora.mp4
Tests
Changelog
Documentation
Dark mode