Skip to content

Conversation

@akalipetis
Copy link
Member

  • feat(registry): update versions from the registry
  • feat(registry): automatically generate version file from registry

Fix CLI-24

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates service and runtime versions across the codebase to align with the latest versions available in the Platform.sh registry. The changes include introducing an automated version generation system that fetches current versions from the registry.

Key changes:

  • Added automated version generation tool that fetches versions from Platform.sh registry
  • Updated service and runtime versions to their latest supported versions (e.g., Redis 6.2→8.0, PostgreSQL 14→17, Python 3.9→3.13)
  • Updated test fixtures and templates to reflect new default versions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/question/models/generate_versions.go New generator tool that fetches and formats version data from registry
internal/question/models/version.go Updated version mappings with latest supported versions from registry
validator/validator_test.go Updated test fixtures to use Redis 8.0 instead of 6.2
platformifier/platformifier_test.go Updated test data with new version arrays and runtime versions
platformifier/templates/upsun/.upsun/config.yaml Updated commented example from PostgreSQL 14 to 17
platformifier/templates/generic/.platform/services.yaml Updated commented example from PostgreSQL 14 to 17

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

MySQL: {"10.6", "10.5", "10.4", "10.3"},
NetworkStorage: {"2.0"},
OpenSearch: {"2", "1.2", "1.1"},
MySQL: {"11.0", "10.11", "10.6", "10.5", "10.4", "10.3"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are deprecated version based on https://docs.upsun.com/add-services/mysql.html#deprecated-versions could we maybe not include them to avoid user to use them on new projects?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that MySQL needs to be treated as a synonym of MariaDB.

(The generation code is correctly only using the supported key from the registry, but the registry has old versions listed for mysql and the correct versions listed for mariadb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants