Publish a Docker image to GHCR on every release #251
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Docker image definition for the upsun CLI and configures a GitHub Actions workflow to build and publish it to GHCR on each release.
- Introduces a
Dockerfileto install the Platform.sh CLI in an Ubuntu-based container - Adds a
publish-ghcr.ymlworkflow triggered on release publish events to build and push the image
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile | Define container with Ubuntu, install dependencies, and set up the Platform.sh CLI installer |
| .github/workflows/publish-ghcr.yml | Configure release-triggered workflow to build and push Docker image to GHCR |
Comments suppressed due to low confidence (3)
Dockerfile:9
- [nitpick] Provide a default value for
VERSIONor document in the README how to supply this build argument so users know which CLI version will be installed.
ARG VERSION=
.github/workflows/publish-ghcr.yml:27
- To maximize platform support, add a
platformsfield in the build step (e.g.,platforms: linux/amd64,linux/arm64) so you publish multi-arch images.
- name: Build and push Docker image
Dockerfile:10
- Piping an external script directly to
bashcan be risky. Consider downloading the installer and verifying its checksum or GPG signature before executing.
RUN curl -fsSL https://raw.githubusercontent.com/platformsh/cli/main/installer.sh | VENDOR=upsun INSTALL_METHOD=raw VERSION=$VERSION bash
| push: true | ||
| tags: | | ||
| ghcr.io/platformsh/upsun-cli:${{ github.event.release.tag_name }} | ||
| ghcr.io/platformsh/upsun-cli:latest |
There was a problem hiding this comment.
seems we should/could make it ghcr.io/upsun/cli
and we should/could also publish ghcr.io/platformsh/cli ? - if so it'd need multiple or generated Dockerfiles
There was a problem hiding this comment.
We can easily parametrize the Dockerfile with a dynamic VENDOR argument for that, no need for multiple or generated Dockerfiles.
The idea was that we don't need a Platform.sh CLI image for now, that's why I didn't mess with it - otherwise I'm happy to adjust.
Co-authored-by: Patrick Dawkins <[email protected]>
| @@ -0,0 +1,13 @@ | |||
| FROM ubuntu:24.04 | |||
There was a problem hiding this comment.
| FROM ubuntu:24.04 | |
| FROM debian:stable-slim |
?
No description provided.