Skip to content

Add initial rewriting framework #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025
Merged

Add initial rewriting framework #15

merged 6 commits into from
Jun 10, 2025

Conversation

Qard
Copy link
Member

@Qard Qard commented May 24, 2025

This is the beginnings of a request rewriting framework. It currently just supports rewriting the path and headers, but could be expanded to modify anything which the RequestBuilder can manage.

I also made some adjustments to the RequestBuilder while I was in there to defer input parsing until the build step so failures can be checked for just once. That simplifies the interface a bit.

@Qard Qard added the enhancement New feature or request label May 24, 2025
@Qard Qard force-pushed the url-rewriting branch from 6eb429b to 48c5ea8 Compare May 24, 2025 16:57
ShogunPanda
ShogunPanda previously approved these changes May 25, 2025
@Qard Qard force-pushed the main branch 5 times, most recently from de91e95 to ec372bc Compare May 26, 2025 15:44
@Qard Qard dismissed stale reviews from simone-sanfratello and ShogunPanda via d43ade0 June 2, 2025 15:30
@Qard Qard force-pushed the url-rewriting branch from 48c5ea8 to d43ade0 Compare June 2, 2025 15:30
@Qard Qard force-pushed the url-rewriting branch 3 times, most recently from 134fc92 to 1a140ab Compare June 5, 2025 12:36
@Qard Qard force-pushed the url-rewriting branch from 1a140ab to cc2a7a1 Compare June 5, 2025 12:43
@Qard Qard force-pushed the url-rewriting branch from 4a04c60 to a310814 Compare June 5, 2025 16:22
@Qard Qard force-pushed the url-rewriting branch from a310814 to d7173d9 Compare June 5, 2025 16:24
@Qard Qard force-pushed the url-rewriting branch 2 times, most recently from 6f2bf6d to 581ab22 Compare June 6, 2025 15:35
@Qard Qard force-pushed the url-rewriting branch 13 times, most recently from d1dd976 to 531348f Compare June 6, 2025 18:10
@Qard Qard force-pushed the url-rewriting branch from 531348f to 3da980f Compare June 6, 2025 18:11
mcollina
mcollina previously approved these changes Jun 9, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Qard Qard dismissed stale reviews from mcollina and simone-sanfratello via edb025a June 9, 2025 11:56
@Qard Qard force-pushed the url-rewriting branch from edb025a to 3394205 Compare June 9, 2025 11:58
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@Qard Qard merged commit 37bfe94 into main Jun 10, 2025
11 checks passed
@Qard Qard deleted the url-rewriting branch June 10, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants