Add initial rewriting framework #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShogunPanda
previously approved these changes
May 25, 2025
mcollina
requested changes
May 26, 2025
simone-sanfratello
previously approved these changes
May 26, 2025
Qard
force-pushed
the
main
branch
5 times, most recently
from
de91e95 to
ec372bc
Compare
Qard
force-pushed
the
url-rewriting
branch
3 times, most recently
from
134fc92 to
1a140ab
Compare
mcollina
reviewed
Jun 5, 2025
Qard
force-pushed
the
url-rewriting
branch
2 times, most recently
from
6f2bf6d to
581ab22
Compare
Qard
force-pushed
the
url-rewriting
branch
13 times, most recently
from
d1dd976 to
531348f
Compare
simone-sanfratello
previously approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginnings of a request rewriting framework. It currently just supports rewriting the path and headers, but could be expanded to modify anything which the RequestBuilder can manage.
I also made some adjustments to the RequestBuilder while I was in there to defer input parsing until the build step so failures can be checked for just once. That simplifies the interface a bit.