-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add item coverage and asset management in DataClient #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a632f22
to
9785a08
Compare
looks good so far! one thing we've been trying to do w/ tests is combine the sync/async calls into a single case since the setup and assertions are the same, the only difference is in invocation... see |
thanks @ischneider I was just trying to follow the existing pattern. This should go into a separate PR. here is an issue for this: #1110 |
9785a08
to
2309d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I tested the CLI and SDK (async and non-async clients), working great for me. Good catch on the missing/commented asset functions.
Co-authored-by: Steve Hillier <[email protected]>
19370ca
to
7c20f21
Compare
The changes focus on improving item assessment(
item-get
,item-coverage
), asset management(asset-get
,asset-list
) and making the API more consistent.item-get
: new in Async client, Sync Client, CLIitem-coverage
: new in Async client, Sync Client, CLIasset-get
: new(un-commented) in CLIasset-list
: new in CLIdocs/cli/cli-data.md
design-docs/CLI-DATA.md
ITEM_TYPE, ID
convention (few examples are out-of-date and no longer work)