Skip to content

Added argument to adjust k8s rate limit #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added argument to adjust k8s rate limit #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41fe07e
added space
suresh-mahawar Aug 18, 2025
a7a7f67
feat(option): added 2 options to adjust k8s rate limit
suresh-mahawar Aug 19, 2025
a90e4bc
fix pointer type
suresh-mahawar Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/draino/draino.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ func main() {
kubecfg = app.Flag("kubeconfig", "Path to kubeconfig file. Leave unset to use in-cluster config.").String()
apiserver = app.Flag("master", "Address of Kubernetes API server. Leave unset to use in-cluster config.").String()
dryRun = app.Flag("dry-run", "Emit an event without cordoning or draining matching nodes.").Bool()
qps = app.Flag("qps", "Queries per second for the Kubernetes API.").Default("5.0").Float32()
burst = app.Flag("burst", "Maximum burst size for the Kubernetes API.").Default("10").Int()
maxGracePeriod = app.Flag("max-grace-period", "Maximum time evicted pods will be given to terminate gracefully.").Default(kubernetes.DefaultMaxGracePeriod.String()).Duration()
evictionHeadroom = app.Flag("eviction-headroom", "Additional time to wait after a pod's termination grace period for it to have been deleted.").Default(kubernetes.DefaultEvictionOverhead.String()).Duration()
drainBuffer = app.Flag("drain-buffer", "Minimum time between starting each drain. Nodes are always cordoned immediately.").Default(kubernetes.DefaultDrainBuffer.String()).Duration()
Expand Down Expand Up @@ -138,6 +140,9 @@ func main() {
c, err := kubernetes.BuildConfigFromFlags(*apiserver, *kubecfg)
kingpin.FatalIfError(err, "cannot create Kubernetes client configuration")

c.QPS = *qps
c.Burst = *burst

cs, err := client.NewForConfig(c)
kingpin.FatalIfError(err, "cannot create Kubernetes client")

Expand Down
2 changes: 1 addition & 1 deletion helm/draino/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
description: draino chart
name: draino
version: 0.1.0
version: 0.1.1
2 changes: 1 addition & 1 deletion helm/draino/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.rbac.create -}}
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ include "draino.fullname" . }}
Expand Down
2 changes: 1 addition & 1 deletion helm/draino/templates/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.rbac.create -}}
apiVersion: rbac.authorization.k8s.io/v1beta1
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "draino.fullname" . }}
Expand Down