Strip markdown from release notes #1758
Conversation
mplorentz
requested review from
joshuatbrown,
pelumy,
bryanmontz and
martindsq
as code owners
| changelog: changelog, | ||
| app_identifier: options[:app_identifier], | ||
| changelog: cleaned_changelog, | ||
| app_identifier: options[:appidentifier], |
There was a problem hiding this comment.
The AI found this bug with appidentifer, and it looks right to me but I'm not sure why it wasn't causing an error before 🤷
|
Do we just want to stop adding the link to the issue in the changelog? Or we want contributors to be able to see the link in the changelog? |
|
I didn't need to run a fastlane build. I don't think I know how to do that. Is there a notion doc for this? I have the last dev build and can see the changes so it works 🎉 . It was strange seeing those builds yesterday, but now I understand why 😄. |
|
The release notes certainly look much nicer this way. As a person who does UAT and QA, I want to see the issue numbers, at least. The URLs were originally necessary because we switched our issues from the Nos repo to the Verse Issues one. I'm not saying the issue numbers need to be in the TestFlight notes. I do need them somewhere, though, so it's 100% clear what issues are solved in a given release. I wonder if GitHub Releases might be a different solution. I just don't have a full grasp on the process yet, so I'm not sure what solution would be best. |
|
Oh! Just realized that maybe the Milestones feature in GitHub is a different way to solve this. If GitHub could tell me "here are the tickets to UAT in the latest staging build", that might work and I might not need the TestFlight release notes at all. I suppose the entire UAT column already tells me that, so maybe the question is really "what tickets in the QA column are in the latest QA/release build?" |
|
No point stressing about this since @mplorentz already created a fix for this by stripping the URLs 😄. I will be approving and merging. Thanks for your thoughts @joshuatbrown. |
I found myself not reading the release notes when I open Nos because they aren't formatted nicely with all the markdown links. I'm not sure if this will totally solve my issue of having glanceable release notes, but it feels like a step in the right direction. Let me know what you think.
How to test
Screenshots/Video