Fix main action button is not visible on iPad on "Build Your Network" onboarding screen #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelumy
requested review from
mplorentz,
joshuatbrown,
bryanmontz and
martindsq
as code owners
|
👀 |
bryanmontz
approved these changes
Feb 6, 2025
|
@pelumy @bryanmontz thanks to both of you for getting this fixed and merged! |
joshuatbrown
pushed a commit
that referenced
this pull request
Feb 6, 2025
…ork-layout Fix main action button is not visible on iPad on "Build Your Network" onboarding screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#184
Description
This PR fixes an issue where the main action button is not visible on iPad on "Build Your Network" onboarding screen.
I removed the scrollview and rearranged the view, making the spacing between the stacked text above, the image and the bottom to be dynamic using a Spacer. I also added a maxWidth to the image to make it expand accordingly with different screen sizes.
How to test
Screenshots/Video