fixed: lists change positions randomly #183 #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested review from
mplorentz,
joshuatbrown,
pelumy and
martindsq
as code owners
bryanmontz
commented
Feb 5, 2025
| @@ -82,11 +82,7 @@ import SwiftUI | |||
| .publisher | |||
| .receive(on: DispatchQueue.main) | |||
| .sink(receiveValue: { [weak self] lists in | |||
| // ensure that we only publish the most recent list for each replaceable identifier | |||
There was a problem hiding this comment.
This extra sorting code was needed while I was building this feature before I was correctly updating existing follow set events in CoreData. I believe it is no longer needed because we only have one event in CoreData for each list.
|
👀 |
|
This fixes the toggle issue for me. I was never able to reproduce the feed title switching positions, so I couldn't confirm that. cc: @joshuatbrown and @mplorentz |
|
approving and merging this because Bryan has included videos showing that the fix works. |
joshuatbrown
pushed a commit
that referenced
this pull request
Feb 6, 2025
fixed: lists change positions randomly #183 # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
https://github.com/verse-pbc/issues/issues/183
Description
Fixes the issue where lists change order randomly.
Steps to Reproduce
Videos
In the before video, you can see that the order of lists is different each time I launch the app. In the after video, the order is always the same.