Refactor the way we close sockets into the RelaySubscriptionManager #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplorentz
requested review from
joshuatbrown,
pelumy,
bryanmontz and
martindsq
as code owners
|
👀 |
pelumy
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks for updating this @mplorentz. It's clearer and easy to follow through for me. I have tested the app and don't find anything strange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
Follow up to #175
Description
This is some refactoring I did while debugging #175 that I stashed away at some point but now I'm submitting it. It basically moves our code for closing relay subscriptions from the
RelayServiceinto theRelaySubscriptionManager. TheRelaySubscriptionManagerhas progressively taken over more of... managing the subscriptions, and this is more of that. I also added more documentation and I think the lifecycle of opening a socket, starting a subscription, closing a subscription, and closing a socket, is easier to follow now that it's all happening in one file.How to test
Launch the app and look for relay problems. This could be rate limit errors in the console, or errors about "too many concurrent REQs", or it could look like content failing to load in the app.