Merge pull request #1 from pl-numiko/fix/html-video-destroy-method

Fix/html video destroy method
pl-numiko · Oct 13, 2024 · 12ace5f · 12ace5f
2 parents e71a802 + 225da45
commit 12ace5f
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 11 deletions.
diff --git a/dist/js/splide-extension-video.cjs.js b/dist/js/splide-extension-video.cjs.js
@@ -2,7 +2,7 @@
  * Splide.js
  * Version  : 0.8.0
  * License  : MIT
- * Copyright: 2022 Naotoshi Fujita
+ * Copyright: 2024 Naotoshi Fujita
  */
 'use strict';
 
@@ -553,7 +553,9 @@ class HTMLVideoPlayer extends AbstractVideoPlayer {
   destroy() {
     super.destroy();
     const { player } = this;
-    const off = player.addEventListener.bind(player);
+    if (!player)
+      return;
+    const off = player.removeEventListener.bind(player);
     off("play", this.onPlay);
     off("pause", this.onPause);
     off("ended", this.onEnded);

diff --git a/dist/js/splide-extension-video.esm.js b/dist/js/splide-extension-video.esm.js
@@ -2,7 +2,7 @@
  * Splide.js
  * Version  : 0.8.0
  * License  : MIT
- * Copyright: 2022 Naotoshi Fujita
+ * Copyright: 2024 Naotoshi Fujita
  */
 function empty(array) {
   array.length = 0;
@@ -549,7 +549,9 @@ class HTMLVideoPlayer extends AbstractVideoPlayer {
   destroy() {
     super.destroy();
     const { player } = this;
-    const off = player.addEventListener.bind(player);
+    if (!player)
+      return;
+    const off = player.removeEventListener.bind(player);
     off("play", this.onPlay);
     off("pause", this.onPause);
     off("ended", this.onEnded);

diff --git a/dist/js/splide-extension-video.js b/dist/js/splide-extension-video.js
diff --git a/dist/js/splide-extension-video.js.map b/dist/js/splide-extension-video.js.map
diff --git a/dist/js/splide-extension-video.min.js b/dist/js/splide-extension-video.min.js
diff --git a/dist/types/players/html/HTMLVideoPlayer.d.ts.map b/dist/types/players/html/HTMLVideoPlayer.d.ts.map
diff --git a/src/js/players/html/HTMLVideoPlayer.ts b/src/js/players/html/HTMLVideoPlayer.ts
@@ -83,7 +83,9 @@ export class HTMLVideoPlayer extends AbstractVideoPlayer<HTMLVideoElement> {
     super.destroy();
 
     const { player } = this;
-    const off = player.addEventListener.bind( player );
+    if ( !player ) return;
+
+    const off = player.removeEventListener.bind( player );
 
     off( 'play', this.onPlay );
     off( 'pause', this.onPause );