pkp/pkp-lib#12009 Add API endpoint to get a list of potential task pa… #12010
Conversation
Vitaliy-1
force-pushed
the
i12009_task_participants
branch
from
80bea16 to
fe9702f
Compare
ewhanson
left a comment
ewhanson
left a comment
There was a problem hiding this comment.
Thanks @Vitaliy-1. Just a few questions, mostly around how things are anonymized. Otherwise, looks good!
|
|
||
| if ($currentUserReviewAssignments->isNotEmpty()) { | ||
| $currentUserHasDoubleBlindReview = (bool) $currentUserReviewAssignments->search(fn (ReviewAssignment $reviewAssignment) => | ||
| $reviewAssignment->getReviewMethod() == ReviewAssignment::SUBMISSION_REVIEW_METHOD_DOUBLEANONYMOUS); |
There was a problem hiding this comment.
I don't know if it matters since they should both be ints but should this be checked with === instead?
| foreach ($stageAssignments as $stageAssignment) { | ||
| if ($isReviewStage && $roleReviewer && $currentUserHasDoubleBlindReview) { | ||
| // Anonymize author if the current user is a reviewer with double-blind review | ||
| if ($stageAssignment->userGroup->roleId == Role::ROLE_ID_AUTHOR) { |
|
|
||
| foreach ($stageAssignments as $stageAssignment) { | ||
| if ($isReviewStage && $roleReviewer && $currentUserHasDoubleBlindReview) { | ||
| // Anonymize author if the current user is a reviewer with double-blind review |
There was a problem hiding this comment.
It may not matter, but it's not completely clear to me going through the code if the authors are being anonymized (i.e. they're included but with no identifiable information) or if they're rather completely excluded (i.e. not available as a participant at all). It seems like the code is excluding them outright, but wanted to double-check because the reference to anonymizing the author were a little confusing to follow.
| $includedReviewAssignments = collect(); | ||
| foreach ($filteredReviewAssignments as $reviewAssignment) { /** @var ReviewAssignment $reviewAssignment */ | ||
|
|
||
| // Check whether participant should be anonymized |
There was a problem hiding this comment.
Same comment about "anonymized" as above.
|
|
||
| return [ | ||
| 'id' => $this->id, | ||
| 'id' => $this?->id, |
There was a problem hiding this comment.
In which cases would $this be potentially null?
2 participants
…rticipants