Skip to content

I11481 2 #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

I11481 2 #11962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01119c1
pkp/pkp-lib#11918 Add public-comments hash to automatically scroll do…
jardakotesovec Oct 15, 2025
9e54cf6
pkp/pkp-lib#11950 Fix submission ID retrieval
Vitaliy-1 Oct 20, 2025
6660406
pkp/pkp-lib#11481 Rehydrate vocabs when publishing/unpublishing
jardakotesovec Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1/submissions/tasks/formRequests/AddTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ protected function prepareForValidation(): void

protected function setSubmission(): Submission
{
return Repo::submission()->get((int) $this->all(['assocId']));
return Repo::submission()->get((int) $this->input('assocId'));
}

protected function getStageId(): int
Expand Down
2 changes: 1 addition & 1 deletion classes/components/UserCommentComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function getLoginUrl()
'login',
null,
null,
['source' => $this->request->getRequestPath()]
['source' => $this->request->getRequestPath() . '#public-comments']
);
}

Expand Down
3 changes: 3 additions & 0 deletions classes/publication/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,8 @@ public function edit(Publication $publication, array $params): Publication
public function publish(Publication $publication)
{
$newPublication = clone $publication;
$newPublication = Repo::controlledVocab()->hydrateVocabsAsEntryData($publication);

$newPublication->stampModified();

$this->setStatusOnPublish($newPublication);
Expand Down Expand Up @@ -650,6 +652,7 @@ abstract protected function setStatusOnPublish(Publication $publication);
public function unpublish(Publication $publication)
{
$newPublication = clone $publication;
$newPublication = Repo::controlledVocab()->hydrateVocabsAsEntryData($publication);
$newPublication->setData('status', Publication::STATUS_QUEUED);
$newPublication->stampModified();

Expand Down