Lookup table #596
Merged
Lookup table #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elshize
force-pushed
the
lookup-table
branch
2 times, most recently
from
0aba011 to
aac2dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 93.84% 93.91% +0.07%
==========================================
Files 81 82 +1
Lines 3897 3929 +32
==========================================
+ Hits 3657 3690 +33
+ Misses 240 239 -1 ☔ View full report in Codecov by Sentry. |
elshize
force-pushed
the
lookup-table
branch
10 times, most recently
from
fc2f633 to
3f6d154
Compare
elshize
force-pushed
the
lookup-table
branch
3 times, most recently
from
0ffb456 to
ed6febf
Compare
elshize
force-pushed
the
lookup-table
branch
3 times, most recently
from
5b3541a to
37531a3
Compare
This lookup table implementation is meant to replace the current lexicon data structure. The overall concept is the same; the aim here is to improve the binary format to allow for extensions, and to improve the interaction with the table from the code, as well as naming convention. This change includes the data structure implementing the mapping concept, a CLI tool to build a table and read data from it, and a unit test suite, as well as CLI tests. In this particular change, we do not introduce any breaking changes. The new code is not used in the already existing tools and workflows. This work will be done in the future. Changelog-added: New lookup table implementation available Signed-off-by: Michal Siedlaczek <[email protected]>
elshize
force-pushed
the
lookup-table
branch
from
37531a3 to
a418c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lookup table implementation is meant to replace the current lexicon
data structure. The overall concept is the same; the aim here is to
improve the binary format to allow for extensions, and to improve the
interaction with the table from the code, as well as naming convention.
This change includes the data structure implementing the mapping
concept, a CLI tool to build a table and read data from it, and a unit
test suite, as well as CLI tests.
In this particular change, we do not introduce any breaking changes. The
new code is not used in the already existing tools and workflows. This
work will be done in the future.