delegate rename, animation speed, storyboard friendliness #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flicts. Changed minimum view width to 100 (I had thumbnails in the master view that size). Added MG_PANESPLITTER_ANIM_DURATION to control the speed of using [UIView animateWithDuration:]. Moved call to [self setup] to viewDidLoad, which makes MGSplitViewController Storyboard-friendly. setSplitPosition now uses [UIView animateWithDuration:] instead of old [UIView beginAnimations .. commitAnimations].
|
Comments from the review on Reviewable.io Classes/MGSplitViewController.m, line 876 [r1] (raw file): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed delegate to splitDelegate to avoid confusion and possible conflicts.
Changed minimum view width to 100. This shouldn't really be hard coded at all though.
Added MG_PANESPLITTER_ANIM_DURATION to control the speed of using [UIView animateWithDuration:].
Moved call to [self setup] to viewDidLoad, which makes MGSplitViewController Storyboard-friendly.
setSplitPosition now uses [UIView animateWithDuration:] instead of old [UIView beginAnimations .. commitAnimations].