Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubectl download URL in install script #5411

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 11, 2024

What this PR does:

This PR does the same as #5379 at the k8s plugin implementation.

Why we need it:

Not to use deprecated download URLs.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@Warashi Warashi enabled auto-merge (squash) December 11, 2024 05:15
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.72%. Comparing base (e276b89) to head (84df237).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5411      +/-   ##
==========================================
- Coverage   25.74%   25.72%   -0.03%     
==========================================
  Files         449      449              
  Lines       48452    48452              
==========================================
- Hits        12474    12464      -10     
- Misses      35005    35014       +9     
- Partials      973      974       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit 8f23da4 into master Dec 11, 2024
17 of 18 checks passed
@Warashi Warashi deleted the k8s-plugin-kubectl-fix-install-script branch December 11, 2024 08:03
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants