Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grafana Tempo helm chart #5396

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 9, 2024

What this PR does:

upgrade tempo chart

Why we need it:

I want to use the config below, introduced at Tempo v2.6.
The helm chart v1.10.2 points to Tempo v2.5.0, so I want to upgrade the chart.

metrics_generator:
  processor:
    local_blocks:
      flush_to_storage: true

ref; https://grafana.com/docs/tempo/latest/release-notes/v2-6/#operational-change-for-traceql-metrics

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Comment on lines +277 to +278
memberlist:
cluster_label: "{{ .Release.Name }}.{{ .Release.Namespace }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change follows the upstream change.
grafana/helm-charts@e66f68a

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.80%. Comparing base (25c55a2) to head (8f6798a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5396      +/-   ##
==========================================
- Coverage   25.81%   25.80%   -0.02%     
==========================================
  Files         450      450              
  Lines       48357    48357              
==========================================
- Hits        12484    12478       -6     
- Misses      34902    34908       +6     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi enabled auto-merge (squash) December 9, 2024 01:28
@Warashi Warashi changed the title Control plane update chart dependencies Update Grafana Tempo helm chart Dec 9, 2024
@Warashi Warashi disabled auto-merge December 9, 2024 01:59
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit dcecc2d into master Dec 9, 2024
17 of 18 checks passed
@Warashi Warashi deleted the control-plane-update-chart-dependencies branch December 9, 2024 02:07
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants