Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipedv1 source code to use only configv1 #5392

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc
t-kikuc previously approved these changes Dec 6, 2024
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 6, 2024 08:07
ffjlabo
ffjlabo previously approved these changes Dec 6, 2024
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Warashi
Warashi previously approved these changes Dec 6, 2024
Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202 khanhtc1202 dismissed stale reviews from Warashi, ffjlabo, and t-kikuc via bb54a01 December 6, 2024 08:13
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 3.17460% with 61 lines in your changes missing coverage. Please review.

Project coverage is 25.81%. Comparing base (1d3b532) to head (bb54a01).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/notifier/notifier.go 0.00% 25 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 15 Missing ⚠️
pkg/configv1/application.go 0.00% 13 Missing ⚠️
pkg/configv1/config.go 0.00% 5 Missing ⚠️
...app/pipedv1/appconfigreporter/appconfigreporter.go 66.66% 0 Missing and 1 partial ⚠️
pkg/app/pipedv1/eventwatcher/eventwatcher.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/trigger/trigger.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
- Coverage   25.83%   25.81%   -0.02%     
==========================================
  Files         450      450              
  Lines       48337    48357      +20     
==========================================
- Hits        12486    12484       -2     
- Misses      34879    34902      +23     
+ Partials      972      971       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit 25c55a2 into master Dec 6, 2024
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the piped-use-configv1 branch December 6, 2024 08:19
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants