Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade react-router-dom from 5.3.4 to 6.0.0 #5207

Merged
merged 25 commits into from
Jan 23, 2025

Conversation

caniszczyk
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • web/package.json
  • web/yarn.lock

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
  738  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.29%. Comparing base (318c997) to head (82c5e98).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5207   +/-   ##
=======================================
  Coverage   26.29%   26.29%           
=======================================
  Files         464      464           
  Lines       49626    49626           
=======================================
  Hits        13047    13047           
  Misses      35546    35546           
  Partials     1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-PATHTOREGEXP-7925106

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi force-pushed the snyk-fix-849485358b2bdf026ba543a01b75d948 branch from 651ec70 to a51e8ae Compare September 11, 2024 04:01
@Warashi
Copy link
Contributor

Warashi commented Sep 11, 2024

We can use react-router-dom-v5-compat for a while.
But we need some modification to use it.
https://www.npmjs.com/package/react-router-dom-v5-compat

Warashi and others added 16 commits September 19, 2024 16:37
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 3, 2025
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

@github-actions github-actions bot closed this Jan 10, 2025
@github-actions github-actions bot deleted the snyk-fix-849485358b2bdf026ba543a01b75d948 branch January 10, 2025 00:20
@khanhtc1202 khanhtc1202 restored the snyk-fix-849485358b2bdf026ba543a01b75d948 branch January 10, 2025 01:46
@khanhtc1202 khanhtc1202 reopened this Jan 10, 2025
@hongky-1994 hongky-1994 force-pushed the snyk-fix-849485358b2bdf026ba543a01b75d948 branch from c822ca7 to 0682ea1 Compare January 23, 2025 02:38
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@khanhtc1202 khanhtc1202 merged commit 40e56cd into master Jan 23, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the snyk-fix-849485358b2bdf026ba543a01b75d948 branch January 23, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants