Skip to content

Add tsc task and fix most compile errors #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2016
Merged

Add tsc task and fix most compile errors #16

merged 3 commits into from
Sep 16, 2016

Conversation

jonaskello
Copy link

@jonaskello jonaskello commented Sep 15, 2016 •
edited
Loading

Fixes most problems in #15

piotrwitek
piotrwitek reviewed Sep 15, 2016
View reviewed changes
src/tsconfig.json
@@ -1,6 +1,7 @@
{
"compileOnSave": false,
"compilerOptions": {
"skipLibCheck": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib check is mandatory

@jonaskello
Copy link
Author

Agreed on skipLibCheck. I set it to false. I also did some more changes in tsconfig and now all compile errors but one is fixed. Specifically I had to change noResolve to false and module to commonjs. I did this by trial and error so not sure why.

The remaining error is this:

src/containers/currency-converter-container/components/currency-valuation-header                            -calendar.tsx(2,22): error TS2307: Cannot find module 'react-input-calendar'.

I think it might be because there are no types installed for react-input-calendar?

@piotrwitek
Copy link
Owner

noResolve makes sense, because it strip out /// references to definition which are used in @types :)
IMO module should be system, because it will validate all various import types not only require
types for react-input-calendar should not be used, because the file actually importing that is not used by main app module, should check and fix includes in tsconfig

piotrwitek
piotrwitek reviewed Sep 16, 2016
View reviewed changes
src/tsconfig.json
"declaration": false,
"jsx": "react",
"module": "es6",
"module": "commonjs",
Copy link
Owner

@piotrwitek piotrwitek Sep 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change

piotrwitek
piotrwitek requested changes Sep 16, 2016
View reviewed changes
Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With few additional fixes I have resolved this issue, please do requested changes and I'll merge this cr

src/tsconfig.json
@@ -30,7 +31,7 @@
"allowJs": false,
"allowSyntheticDefaultImports": true,
"noImplicitUseStrict": false,
"lib": ["es5", "es6", "es2016.array.include"],
"lib": ["es5", "es6", "es2016.array.include", "dom", "es2016.array.include", "es2015.promise", "es2017.object", "es2015.iterable"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove doubled es2016.array.include

@jonaskello
Copy link
Author

I think the requested changes are in now :-)

@piotrwitek piotrwitek merged commit deaaf4b into piotrwitek:master Sep 16, 2016
@piotrwitek
Copy link
Owner

@jonaskello merged, please check updated readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek piotrwitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaskello @piotrwitek