Fix: Reattaching an element does not re-run the effects #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ae8c96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cristinecula
changed the title
✅ Deploy Preview for pionjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cristinecula
force-pushed
the
feature/use-effect-reattach-bug
branch
from
a7bd828 to
1f8b39d
Compare
Also handled situation where teardown was ran multiple times when reattaching. Fixes #58
cristinecula
force-pushed
the
feature/use-effect-reattach-bug
branch
from
1f8b39d to
1ae8c96
Compare
megheaiulian
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
Amazing work @cristinecula. Thank you for fixing this nasty bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by resetting the internal state of effects when the element is disconnected. This ensures that when it is reconnected, it will run all effects.
Also fixed an issue where the teardown function is ran twice when re-attaching (once when you detach and once when you attach).
Re matthewp/haunted#492
Re #58