Fix deserialization of GenericScimResource.#299
Merged
Conversation
Jackson 3 enabled the DeserializationFeature.FAIL_ON_TRAILING_TOKENS setting by default. This caused problems for the custom deserializer since extra JSON data can be present if a GenericScimResource is embedded within a list response. As a result, this commit updates the deserializer to address this edge case. This also includes a nullability annotation correction and minor test cleanup. Reviewer: dougbulkley Reviewer: vyhhuang JiraIssue: DS-51507
dougbulkley
approved these changes
May 21, 2026
vyhhuang
approved these changes
May 21, 2026
vyhhuang
left a comment
vyhhuang
left a comment
Collaborator
There was a problem hiding this comment.
These changes look fine to me.
kqarryzada
commented
May 21, 2026
| @@ -130,13 +118,6 @@ public void testBasicParsing() throws Exception | |||
| Meta meta = cso.getMeta(); | |||
| Assert.assertNotNull(meta); | |||
|
|
|||
| Assert.assertEquals( | |||
| dateFormat.format(meta.getCreated().getTime()), | |||
| "2015-02-27T11:28:39.042Z"); | |||
Collaborator
Author
There was a problem hiding this comment.
I forgot to mention, but I removed these since I originally swapped it with DateTimeUtils.format(). That was better than using a manual formatter that only supports UTC. However, I realized that the next case using ObjectNode already implicitly calls into this. Thus, I removed this so it wouldn't be duplicitous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson 3 enabled the DeserializationFeature.FAIL_ON_TRAILING_TOKENS setting by default. This caused problems for the custom deserializer since extra JSON data can be present if a GenericScimResource is embedded within a list response. As a result, this commit updates the deserializer to address this edge case.
This also includes a nullability annotation correction and minor test cleanup.
Reviewer: dougbulkley
Reviewer: vyhhuang
JiraIssue: DS-51507