test(server): keep provider fixture directories host-portable - #9572
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
89092d7 to
0a640be
Compare
0a640be to
ad8d0ea
Compare
e1ede66 to
680f112
Compare
680f112 to
f534ae7
Compare
efff454 to
cf19766
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The runtime changes are confined to test cleanup and host-temporary-directory portability, with no product request-path impact. However, the PR adds a file-level Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
cf19766 to
ff82da2
Compare
ff82da2 to
679a18f
Compare
679a18f to
bc8fff5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit bc8fff5. Configure here.
bc8fff5 to
52e69f8
Compare
… dir The capabilities probe aborts the SDK query without waiting for the child to exit, and on Windows a directory that is still some process's cwd cannot be removed, so the scoped temp directory's rmdir hit EBUSY. Give the fake CLI's workspace its own directory whose removal retries until the child has gone. Co-Authored-By: Claude Code <noreply@anthropic.com>
52e69f8 to
8170118
Compare

The Claude capabilities probe can abort before its child has fully exited. On Windows, keeping that child’s cwd inside the scoped fixture makes cleanup fail with EBUSY. The Codex collaboration fixture also hard-coded /tmp, which does not exist on Windows.
Give the Claude child a separate temporary cwd with retrying final cleanup, and use the host temporary directory for Codex collaboration sessions. The provider behavior and assertions are unchanged.
Part of the Windows test-suite stack rooted at #9564; the manual Windows lane comes from #9538.
Originally prepared with Claude Fable 5 in Claude Code; finalized with GPT-5.6 Sol in T3 Code.
Note
Low Risk
Test-only fixture and cleanup changes; no production code paths or assertion changes.
Overview
Makes two provider integration tests reliable on Windows by fixing how temporary working directories are created and torn down. Production provider behavior and test assertions are unchanged.
Claude capabilities probe SDK test: The fake child’s workspace
cwdis no longer nested inside the scoped fixture directory. It is created as its own temp folder and removed in a finalizer vianode:fs/promisesrmwith retries (instead of Effect scheduling, which would stall underTestClock). That avoids EBUSY when the probe aborts the SDK before the child exits and still holds the directory ascwd.Codex collab runtime integration tests: Every
makeCodexSessionRuntimecall that used a hard-coded/tmpcwdnow usesos.tmpdir(), so sessions run against the host temp path on Windows and Unix alike.Reviewed by Cursor Bugbot for commit 8170118. Bugbot is set up for automated code reviews on this repo. Configure here.