Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix misc spelling #2504

Merged
merged 1 commit into from
Feb 10, 2025
Merged

*: Fix misc spelling #2504

merged 1 commit into from
Feb 10, 2025

Conversation

ottok
Copy link
Contributor

@ottok ottok commented Feb 2, 2025

Replace misspelled words:

adminstrator
ans
automaticlly
becase
build-in
calles
chanel
comonent
compatiability
componet
curretly
devided
dirctory
dispaly
droping
envionment
errror
failes
fileds
fisrt
fuctions
genreated
gernerate
gloabl
implemention
implment
ingore
interupted
keep-alives
lable
lastest
occured
unexpect
quering
quiting
refrence
reletive
runing
setted
shoule
specifid
specifing
speficied
storeage
suprise
tarbal
thant
verion
vesions

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Replace misspelled words:

    adminstrator
    ans
    automaticlly
    becase
    build-in
    calles
    chanel
    comonent
    compatiability
    componet
    curretly
    devided
    dirctory
    dispaly
    droping
    envionment
    errror
    failes
    fileds
    fisrt
    fuctions
    genreated
    gernerate
    gloabl
    implemention
    implment
    ingore
    interupted
    keep-alives
    lable
    lastest
    occured
    unexpect
    quering
    quiting
    refrence
    reletive
    runing
    setted
    shoule
    specifid
    specifing
    speficied
    storeage
    suprise
    tarbal
    thant
    verion
    vesions
@CLAassistant
Copy link

CLAassistant commented Feb 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from breezewish February 2, 2025 11:34
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2025

Welcome @ottok! It looks like this is your first PR to pingcap/tiup 🎉

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2025
@ottok
Copy link
Contributor Author

ottok commented Feb 2, 2025

FYI @dveeden

Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2025

@dveeden: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor

dveeden commented Feb 2, 2025

/cc @srstack

@ti-chi-bot ti-chi-bot bot requested a review from srstack February 2, 2025 11:46
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-03 11:01:34.509602339 +0000 UTC m=+96766.042014336: ☑️ agreed by breezewish.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (8e15a03) to head (d7a3444).
Report is 5 commits behind head on master.

Current head d7a3444 differs from pull request most recent head 0349952

Please upload reports for the commit 0349952 to get more accurate results.

Files with missing lines Patch % Lines
pkg/cluster/executor/scp.go 0.00% 2 Missing ⚠️
pkg/repository/clone_mirror.go 0.00% 2 Missing ⚠️
pkg/cluster/manager/builder.go 0.00% 1 Missing ⚠️
pkg/cluster/manager/patch.go 0.00% 1 Missing ⚠️
pkg/cluster/manager/scale_out.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/tikv.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/tispark.go 0.00% 1 Missing ⚠️
pkg/repository/merge_mirror.go 0.00% 1 Missing ⚠️
pkg/repository/mirror.go 0.00% 1 Missing ⚠️
pkg/tui/progress/display_props.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2504      +/-   ##
==========================================
- Coverage   53.17%   53.15%   -0.02%     
==========================================
  Files         336      336              
  Lines       36416    36415       -1     
==========================================
- Hits        19364    19356       -8     
- Misses      14692    14698       +6     
- Partials     2360     2361       +1     
Flag Coverage Δ
tiup 33.81% <25.00%> (-0.05%) ⬇️
unittest 21.63% <18.75%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dveeden
Copy link
Contributor

dveeden commented Feb 10, 2025

/retest

@xhebox xhebox merged commit 5454848 into pingcap:master Feb 10, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants