-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Add --mode=tiflash-disagg #2492
Conversation
…iously) Signed-off-by: Wish <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2492 +/- ##
==========================================
- Coverage 52.11% 42.42% -9.69%
==========================================
Files 335 335
Lines 36379 36399 +20
==========================================
- Hits 18957 15439 -3518
- Misses 15109 19031 +3922
+ Partials 2313 1929 -384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wish <[email protected]>
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
What is changed and how it works?
Previously #2194 introduced --mode=tidb-disagg, and later I removed it and substituted it with --mode=tidb-cse in #2386.
However, it turns out that actually we need both mode in daily development, so this PR add back tidb-disagg mode (and renamed it to tiflash-disagg mode for better name).
Check List
Tests
Release notes: