Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Add --mode=tiflash-disagg #2492

Merged
merged 7 commits into from
Jan 20, 2025

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jan 15, 2025

What problem does this PR solve?

What is changed and how it works?

Previously #2194 introduced --mode=tidb-disagg, and later I removed it and substituted it with --mode=tidb-cse in #2386.

However, it turns out that actually we need both mode in daily development, so this PR add back tidb-disagg mode (and renamed it to tiflash-disagg mode for better name).

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

playground: Add --mode=tiflash-disagg

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack January 15, 2025 23:59
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2025
@breezewish breezewish changed the title playground: Add tiflash-disagg mode playground: Add --mode=tiflash-disagg Jan 16, 2025
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 43.66197% with 40 lines in your changes missing coverage. Please review.

Project coverage is 42.42%. Comparing base (f57aa1d) to head (1fbe561).
Report is 1 commits behind head on master.

Current head 1fbe561 differs from pull request most recent head d12dd36

Please upload reports for the commit d12dd36 to get more accurate results.

Files with missing lines Patch % Lines
components/playground/instance/tiflash_config.go 0.00% 18 Missing ⚠️
components/playground/playground.go 27.78% 11 Missing and 2 partials ⚠️
components/playground/instance/tidb_config.go 0.00% 2 Missing and 2 partials ⚠️
components/playground/instance/tiflash.go 50.00% 1 Missing and 1 partial ⚠️
components/playground/instance/pd_config.go 66.67% 0 Missing and 1 partial ⚠️
components/playground/instance/tikv_config.go 0.00% 0 Missing and 1 partial ⚠️
components/playground/main.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
- Coverage   52.11%   42.42%   -9.69%     
==========================================
  Files         335      335              
  Lines       36379    36399      +20     
==========================================
- Hits        18957    15439    -3518     
- Misses      15109    19031    +3922     
+ Partials     2313     1929     -384     
Flag Coverage Δ
playground 16.16% <43.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 20, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-20 08:43:50.789585941 +0000 UTC m=+83958.120505344: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 0791a28 into pingcap:master Jan 20, 2025
19 of 20 checks passed
@breezewish breezewish deleted the wenxuan/tiflashdisagg branch January 20, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants