-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uninstall: more clearly messages #2488
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
- Coverage 52.11% 44.24% -7.87%
==========================================
Files 335 335
Lines 36379 36379
==========================================
- Hits 18957 16095 -2862
- Misses 15109 18287 +3178
+ Partials 2313 1997 -316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
@makocchi-git: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @xhebox |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Currently,
tiup unintall xxx
shows only directory name that was deleted.This PR implements more clearly messages.
What is changed and how it works?
This PR changes only output messages.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: