Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix typo #2487

Merged
merged 1 commit into from
Jan 8, 2025
Merged

*: fix typo #2487

merged 1 commit into from
Jan 8, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 8, 2025

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack January 8, 2025 06:59
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@rleungx
Copy link
Member Author

rleungx commented Jan 8, 2025

@xhebox PTAL

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (abc1b45) to head (8b11f48).
Report is 1 commits behind head on master.

Current head 8b11f48 differs from pull request most recent head f48d8ed

Please upload reports for the commit f48d8ed to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2487      +/-   ##
==========================================
+ Coverage   47.55%   47.59%   +0.03%     
==========================================
  Files         336      335       -1     
  Lines       36398    36372      -26     
==========================================
  Hits        17308    17308              
+ Misses      16981    16955      -26     
  Partials     2109     2109              
Flag Coverage Δ
tiup 33.81% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-08 08:09:36.226565069 +0000 UTC m=+341119.515396773: ☑️ agreed by xhebox.

@xhebox xhebox merged commit f57aa1d into pingcap:master Jan 8, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants