Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide other password args #2436

Merged
merged 4 commits into from
Jul 14, 2024
Merged

hide other password args #2436

merged 4 commits into from
Jul 14, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jul 9, 2024

What problem does this PR solve?

As title.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
[xhe@M1PRO-2 tiup]$ ./bin/tiup tidb-lightning:v6.5.3 --tidb-password tidb
Starting component tidb-lightning: /Users/xhe/.tiup/components/tidb-lightning/v6.5.3/tidb-lightning --tidb-password ******
Verbose debug logs will be written to /var/folders/4q/x954lkc95gl34qjnx2hbcr640000gn/T/lightning.log.2024-07-09T14.51.18+0800
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Redact `--tidb-password` arguments for tidb-lightning

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack July 9, 2024 06:49
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2024
Signed-off-by: xhe <[email protected]>
var record []string
redactArgs := []string{
"-p",
"--tidb-password",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any other possible password arguments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another for dumpling, and comments, PTAL

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 10, 2024
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jul 10, 2024
@xhebox xhebox requested a review from bb7133 July 11, 2024 07:17
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 12, 2024
@xhebox
Copy link
Collaborator Author

xhebox commented Jul 14, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 14, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jul 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-10 03:23:49.58539108 +0000 UTC m=+414326.820625190: ☑️ agreed by bb7133.
  • 2024-07-10 07:53:25.602794556 +0000 UTC m=+430502.838028661: ✖️🔁 reset by xhebox.
  • 2024-07-12 07:58:26.40015249 +0000 UTC m=+603603.635386602: ☑️ agreed by bb7133.
  • 2024-07-14 14:24:31.534695062 +0000 UTC m=+191093.525636532: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2024

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Collaborator Author

xhebox commented Jul 14, 2024

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2024

@xhebox: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox xhebox merged commit 342c767 into pingcap:master Jul 14, 2024
19 of 20 checks passed
@xhebox xhebox deleted the redact branch July 14, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants