Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test ci #2352

Closed
wants to merge 2 commits into from
Closed

test ci #2352

wants to merge 2 commits into from

Conversation

Yujie-Xie
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 8, 2024 08:33
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1210bc2) 55.53% compared to head (eae0c1c) 55.53%.

❗ Current head eae0c1c differs from pull request most recent head 8c84868. Consider uploading reports for the commit 8c84868 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2352   +/-   ##
=======================================
  Coverage   55.53%   55.53%           
=======================================
  Files         329      329           
  Lines       34836    34848   +12     
=======================================
+ Hits        19344    19351    +7     
- Misses      13179    13192   +13     
+ Partials     2313     2305    -8     
Flag Coverage Δ
cluster 44.96% <100.00%> (+0.09%) ⬆️
playground 15.38% <0.00%> (+<0.01%) ⬆️
tiup 33.59% <ø> (ø)
unittest 22.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yujie-Xie Yujie-Xie closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants