Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: init some pd configuration #2351

Merged
merged 1 commit into from
Jan 5, 2024
Merged

playground: init some pd configuration #2351

merged 1 commit into from
Jan 5, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jan 4, 2024

What problem does this PR solve?

close tikv/pd#7507

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Before:

image

After:

image
config:

➜  pd-0 cat pd.toml
[schedule]
patrol-region-interval = "100ms"

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar January 4, 2024 10:18
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9acd306) 55.38% compared to head (8397fc2) 55.54%.

❗ Current head 8397fc2 differs from pull request most recent head 292fae3. Consider uploading reports for the commit 292fae3 to get more accurate results

Files Patch % Lines
components/playground/instance/pd.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
+ Coverage   55.38%   55.54%   +0.16%     
==========================================
  Files         328      329       +1     
  Lines       34825    34836      +11     
==========================================
+ Hits        19287    19349      +62     
+ Misses      13230    13175      -55     
- Partials     2308     2312       +4     
Flag Coverage Δ
playground 15.37% <78.57%> (+0.05%) ⬆️
tiup 33.56% <ø> (ø)
unittest 22.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!!

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 01:50:45.101358579 +0000 UTC m=+2394536.138585506: ☑️ agreed by breezewish.

@breezewish breezewish merged commit 768dea3 into master Jan 5, 2024
5 checks passed
@breezewish breezewish deleted the reduce-pd-cpu branch January 5, 2024 01:51
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running a pd-server affect the battery life of a local mbp
4 participants