-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: tiproxy needs to override usercfg #2342
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2342 +/- ##
==========================================
- Coverage 55.42% 55.05% -0.37%
==========================================
Files 328 328
Lines 34828 34827 -1
==========================================
- Hits 19300 19172 -128
- Misses 13218 13356 +138
+ Partials 2310 2299 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Close #2339
previously, it doesnt override user config correctly leading to port conflicts when using custom configs for multiple tiproxy instances. TiDB pass ports by cli flags so then are fine.
Also, log-file is not passed
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: