-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/dm: support deploying Prometheus witch custom command parameters #2340
Conversation
Welcome @WalterWj! It looks like this is your first PR to pingcap/tiup 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
+ Coverage 53.39% 55.33% +1.94%
==========================================
Files 328 328
Lines 34823 34825 +2
==========================================
+ Hits 18593 19270 +677
+ Misses 13971 13242 -729
- Partials 2259 2313 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think “additional_args” is a more clear name than "more_command" |
Done |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@WalterWj: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@WalterWj: Please do not delete or edit you lgtm type comment! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Some users want to turn on Prometheus's hot load feature. Or add some Prometheus commands manually
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: