Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/dm: support deploying Prometheus witch custom command parameters #2340

Merged
merged 9 commits into from
Dec 28, 2023

Conversation

WalterWj
Copy link
Contributor

What problem does this PR solve?

Some users want to turn on Prometheus's hot load feature. Or add some Prometheus commands manually

What is changed and how it works?

img_v3_026g_107a4e8a-896d-4d8d-bf72-18df26c2131g
img_v3_026g_1a83581c-afcd-4488-934e-3f8ea6ad203g

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack December 26, 2023 07:58
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2023

Welcome @WalterWj! It looks like this is your first PR to pingcap/tiup 🎉

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 26, 2023
@WalterWj
Copy link
Contributor Author

image
image

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4800a90) 53.39% compared to head (a2ff03c) 55.33%.

❗ Current head a2ff03c differs from pull request most recent head e1d2e70. Consider uploading reports for the commit e1d2e70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
+ Coverage   53.39%   55.33%   +1.94%     
==========================================
  Files         328      328              
  Lines       34823    34825       +2     
==========================================
+ Hits        18593    19270     +677     
+ Misses      13971    13242     -729     
- Partials     2259     2313      +54     
Flag Coverage Δ
cluster 44.68% <100.00%> (+2.68%) ⬆️
dm 25.45% <100.00%> (-0.04%) ⬇️
playground 15.29% <0.00%> (-<0.01%) ⬇️
tiup 33.56% <ø> (-0.05%) ⬇️
unittest 22.36% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WalterWj WalterWj requested a review from srstack December 27, 2023 02:42
@kaaaaaaang
Copy link
Collaborator

I think “additional_args” is a more clear name than "more_command"

@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Dec 27, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 27, 2023
@WalterWj
Copy link
Contributor Author

Update run_command to additional_args
image
image

@WalterWj
Copy link
Contributor Author

I think “additional_args” is a more clear name than "more_command"

Done

@kaaaaaaang kaaaaaaang changed the title tiup deploys Prometheus to define command parameters cluster/dm: support deploying Prometheus witch custom command parameters Dec 27, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 27, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 27, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 27, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

@WalterWj: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor Author

@WalterWj WalterWj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

@WalterWj: Please do not delete or edit you lgtm type comment!

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 28, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-26 10:12:39.622997225 +0000 UTC m=+1560650.660224140: ☑️ agreed by srstack.
  • 2023-12-27 02:55:58.394762489 +0000 UTC m=+1620849.431989414: ✖️🔁 reset by WalterWj.
  • 2023-12-27 05:22:24.90362279 +0000 UTC m=+1629635.940849712: ☑️ agreed by kaaaaaaang.
  • 2023-12-27 06:45:34.449214075 +0000 UTC m=+1634625.486441002: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-12-28 02:33:39.467354155 +0000 UTC m=+1705910.504581067: ☑️ agreed by srstack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants