add tibr controller #6223

grovecai · 2025-05-29T07:19:03Z

Support following operations

create / delete with/without tls
support pod and pvc overlay
cluster deleted
cluster suspend
cluster pause

what is not?

support tibr update. ps: recreate as workround
e2e test

What problem does this PR solve?

What is changed and how does it work?

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot · 2025-05-29T07:19:13Z

Hi @grovecai. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2025-05-29T07:19:18Z

/run-pull-e2e-kind-v2

github-actions · 2025-05-30T07:32:31Z

/run-pull-e2e-kind-v2

github-actions · 2025-05-30T08:55:09Z

/run-pull-e2e-kind-v2

github-actions · 2025-05-30T10:18:20Z

/run-pull-e2e-kind-v2

github-actions · 2025-05-31T16:16:29Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-01T09:22:49Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-01T12:12:30Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-01T12:24:25Z

/run-pull-e2e-kind-v2

codecov-commenter · 2025-06-01T12:30:35Z

Codecov Report

Attention: Patch coverage is 36.45700% with 495 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (af57199) to head (173a49d).

Additional details and impacted files

@@              Coverage Diff               @@
##           feature/v2    #6223      +/-   ##
==============================================
- Coverage       47.43%   47.03%   -0.40%     
==============================================
  Files             283      295      +12     
  Lines           18762    19541     +779     
==============================================
+ Hits             8899     9192     +293     
- Misses           9863    10349     +486

Flag	Coverage Δ
unittest	`47.03% <36.45%> (-0.40%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-06-01T13:08:51Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-02T11:28:30Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-02T11:51:42Z

/run-pull-e2e-kind-v2

charts/tidb-operator/templates/rbac.yaml

cmd/tidb-operator/main.go

pkg/controllers/br/tibr/tasks/cm.go

pkg/controllers/br/tibr/tasks/pvc.go

github-actions · 2025-06-03T12:45:56Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-03T12:49:02Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-04T01:38:05Z

/run-pull-e2e-kind-v2

liubog2008 · 2025-06-04T06:26:28Z

api/br/v1alpha1/tibr_types.go

+	// Define this as array for future extension
+	// +listType=map
+	// +listMapKey=name
+	// +kubebuilder:validation:MaxItems=1


currently, only need one optional volume "data"

liubog2008 · 2025-06-04T06:30:14Z

pkg/controllers/br/tibr/tasks/sts.go

+
+		Spec: appsv1.StatefulSetSpec{
+			ServiceName: HeadlessSvcName(tibr),
+			Replicas:    ptr.To(StatefulSetReplica),


If only one replica is needed, I think using pod directly is better than using statefulset.

as discuss offline, statefulset is easy satisfy auto restart and auto pv provisioning.

liubog2008 · 2025-06-04T06:34:36Z

pkg/controllers/br/tibr/tasks/utils.go

+}
+
+func StatefulSetName(tibr *v1alpha1br.TiBR) string {
+	return tibr.Name + "-sts"


add component name into all kubernetes resources to avoid name conflict.

normally {groupName}-{component}-{custom name}

github-actions · 2025-06-04T07:55:50Z

/run-pull-e2e-kind-v2

github-actions · 2025-06-04T08:17:56Z

/run-pull-e2e-kind-v2

liubog2008 · 2025-06-05T02:29:15Z

/lgtm

ti-chi-bot · 2025-06-05T02:29:20Z

[LGTM Timeline notifier]

Timeline:

2025-06-05 02:29:20.046654447 +0000 UTC m=+495246.248999713: ☑️ agreed by liubog2008.

ti-chi-bot · 2025-06-05T02:29:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [liubog2008]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot bot added the do-not-merge/work-in-progress label May 29, 2025

ti-chi-bot bot requested review from howardlau1999 and shonge May 29, 2025 07:19

ti-chi-bot bot added contribution needs-ok-to-test labels May 29, 2025

github-actions bot added the v2 for operator v2 label May 29, 2025

ti-chi-bot bot added the size/XXL label May 29, 2025

grovecai force-pushed the yuanrui/tibrc branch from 1548786 to c421ee3 Compare May 30, 2025 07:32

grovecai force-pushed the yuanrui/tibrc branch from c421ee3 to 774c5ac Compare May 30, 2025 08:54

grovecai force-pushed the yuanrui/tibrc branch from 774c5ac to e0c587b Compare May 30, 2025 10:18

grovecai force-pushed the yuanrui/tibrc branch from e0c587b to 04ff592 Compare May 31, 2025 16:16

grovecai force-pushed the yuanrui/tibrc branch from 04ff592 to d5604b7 Compare June 1, 2025 09:22

grovecai force-pushed the yuanrui/tibrc branch from d5604b7 to 2c43b32 Compare June 1, 2025 12:12

grovecai changed the title ~~WIP: add tibr controller~~ add tibr controller Jun 1, 2025

ti-chi-bot bot removed the do-not-merge/work-in-progress label Jun 1, 2025

grovecai force-pushed the yuanrui/tibrc branch from 2c43b32 to d06e327 Compare June 1, 2025 12:24

add tibr controller

21a12d4

grovecai force-pushed the yuanrui/tibrc branch from d06e327 to 21a12d4 Compare June 1, 2025 13:08

add ut for sts

847708f

fix status update

230b9f2

fgksgf reviewed Jun 3, 2025

View reviewed changes

charts/tidb-operator/templates/rbac.yaml Show resolved Hide resolved

cmd/tidb-operator/main.go Outdated Show resolved Hide resolved

pkg/controllers/br/tibr/tasks/cm.go Outdated Show resolved Hide resolved

pkg/controllers/br/tibr/tasks/pvc.go Show resolved Hide resolved

grovecai force-pushed the yuanrui/tibrc branch from 2b428a9 to dadf0c8 Compare June 3, 2025 12:48

grovecai force-pushed the yuanrui/tibrc branch from dadf0c8 to 725687f Compare June 4, 2025 01:37

liubog2008 reviewed Jun 4, 2025

View reviewed changes

grovecai force-pushed the yuanrui/tibrc branch from 725687f to 4194840 Compare June 4, 2025 07:55

add volumes and resources definition; small fixes

173a49d

grovecai force-pushed the yuanrui/tibrc branch from 4194840 to 173a49d Compare June 4, 2025 08:17

ti-chi-bot bot added the lgtm label Jun 5, 2025

ti-chi-bot bot added the approved label Jun 5, 2025

ti-chi-bot bot merged commit 283e8b1 into pingcap:feature/v2 Jun 5, 2025
9 checks passed

grovecai deleted the yuanrui/tibrc branch July 29, 2025 02:49

add tibr controller #6223

add tibr controller #6223

Uh oh!

Conversation

grovecai commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

Uh oh!

ti-chi-bot bot commented May 29, 2025

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented May 31, 2025

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

codecov-commenter commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

liubog2008 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

grovecai Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

liubog2008 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

grovecai Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

liubog2008 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

liubog2008 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

grovecai Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

github-actions bot commented Jun 4, 2025

Uh oh!

liubog2008 commented Jun 5, 2025

Uh oh!

ti-chi-bot bot commented Jun 5, 2025

grovecai commented May 29, 2025 •

edited

Loading

codecov-commenter commented Jun 1, 2025 •

edited

Loading