deps: bump client-go for nextgen shared lock#5205
Conversation
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
📝 WalkthroughWalkthroughThis PR updates two Go module dependencies to newer commits: ChangesDependency Updates
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the github.com/pingcap/kvproto and github.com/tikv/client-go/v2 dependencies to newer versions in go.mod and go.sum. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@tenfyzhong @3AceShowHand @wk989898 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test next-gen |
What problem does this PR solve?
Issue Number: ref #5206
TiCDC master still depends on an older
github.com/tikv/client-go/v2revision that does not contain the API v2 lock-key re-encoding fix needed by the TiDB shared-lock feature.Related TiDB issue: pingcap/tidb#66154
Client-go fix PR: tikv/client-go#1987
This PR follows the same dependency strategy as #5203 and consumes the minimal client-go branch for TiCDC:
github.com/tikv/client-go/v2 v2.0.8-0.20260605035552-78dc334b882bWhat is changed and how it works?
github.com/tikv/client-go/v2to the minimal78dc334pseudo-version.github.com/pingcap/kvprotoonly as required by that client-go version.github.com/pingcap/tidb,github.com/tikv/pd/client,google.golang.org/grpc, andgolang.org/x/*unchanged.Check List
Tests
Local checks run:
go mod tidygit diff --checkNEXT_GEN=1 make cdcgo test --tags=nextgen ./cmd/cdcgo test --tags=nextgen ./pkg/txnutil/gc/...go test --tags=nextgen ./logservice/logpuller/...go test --tags=nextgen ./logservice/txnutil/...go test --tags=nextgen -timeout=2m ./pkg/upstream/...Note:
pkg/pdutil/TestGetSourceIDtimes out locally in the same way on cleanorigin/master, so it is not introduced by this dependency bump.Questions
Will it cause performance regression or break compatibility?
No expected compatibility impact. The dependency change is limited to client-go and its required kvproto version for shared-lock support.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note