brpb: add filtered_out flag for pitr map #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Mou <[email protected]>
YuJuncen
reviewed
Feb 5, 2025
proto/brpb.proto
Outdated
| } | ||
|
|
||
| message PitrDBMap{ | ||
| string name = 1; | ||
| IDMap id_map = 2; | ||
| repeated PitrTableMap tables = 3; | ||
| bool filtered = 4; // whether this db has been filtered out |
There was a problem hiding this comment.
You may put this comment above the field, then the generated code will contain this comment. Also perhaps name this field filtered_out?
There was a problem hiding this comment.
good to know, thanks!
Signed-off-by: Wenqi Mou <[email protected]>
Tristan1900
changed the title
Tristan1900
changed the title
YuJuncen
approved these changes
Feb 5, 2025
overvenus
approved these changes
Feb 5, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: overvenus, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bool to indicate whether entry should be filtered out or not, we need this information persisted.